fix(forms): properly handle the change to the FormGroup shape #40829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2021
Contributor
Author
packages/forms/src/directives/reactive_directives/form_group_directive.ts
Outdated
Show resolved
Hide resolved
packages/forms/src/directives/reactive_directives/form_group_directive.ts
Outdated
Show resolved
Hide resolved
07bab94 to
8163e9c
Compare
Currently the code in the `FormGroupDirective` assumes that the shape of the underlying `FormGroup` never changes and `FormControl`s are not replaced with other types. In practice this is possible and Forms code should be able to process such changes in FormGroup shape. This commit adds extra check to the `FormGroupDirective` class to avoid applying FormControl-specific to other types. Fixes angular#13788.
1e6985b to
f32ce49
Compare
Contributor
Author
petebacondarwin
approved these changes
Mar 12, 2021
jessicajaniuk
pushed a commit
that referenced
this pull request
Mar 12, 2021
Currently the code in the `FormGroupDirective` assumes that the shape of the underlying `FormGroup` never changes and `FormControl`s are not replaced with other types. In practice this is possible and Forms code should be able to process such changes in FormGroup shape. This commit adds extra check to the `FormGroupDirective` class to avoid applying FormControl-specific to other types. Fixes #13788. PR Close #40829
This was referenced Mar 17, 2021
Merged
Closed
This was referenced Mar 18, 2021
Closed
Merged
Closed
Closed
2 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code in the
FormGroupDirectiveassumes that the shape of the underlyingFormGroupneverchanges and
FormControls are not replaced with other types. In practice this is possible and Forms codeshould be able to process such changes in FormGroup shape.
This commit adds extra check to the
FormGroupDirectiveclass to avoid applying FormControl-specific toother types.
Fixes #13788.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?