[patch-only] perf(forms): make built-in ControlValueAccessors more tree-shakable (#41146) #41197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngular#41146) This commit updates Forms code to avoid direct references to all built-in ControlValueAccessor classes, which prevents their tree-shaking from production builds. Instead, a new static property is added to all built-in ControlValueAccessors, which is checked when we need to identify whether a given ControlValueAccessors is a built-in one. PR Close angular#41146
jessicajaniuk
approved these changes
Mar 13, 2021
Contributor
|
Closed by commit 5908eda |
jessicajaniuk
pushed a commit
that referenced
this pull request
Mar 13, 2021
…41146) (#41197) This commit updates Forms code to avoid direct references to all built-in ControlValueAccessor classes, which prevents their tree-shaking from production builds. Instead, a new static property is added to all built-in ControlValueAccessors, which is checked when we need to identify whether a given ControlValueAccessors is a built-in one. PR Close #41146 PR Close #41197
This was referenced Mar 17, 2021
Merged
Closed
This was referenced Mar 18, 2021
Closed
Merged
Closed
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a patch-only version of #41146, since it had merge conflicts with the patch branch.