Specialized error when depending on an Ivy-compiled NgModule, 10.2.x edition #41598
Conversation
…lar#41534) When an Ivy NgModule is imported into a View Engine build, it doesn't have metadata.json files that describe it as an NgModule, so it appears to VE builds as a plain, undecorated class. The error message shown in this situation generic and confusing, since it recommends adding an @NgModule annotation to a class from a library. This commit adds special detection into the View Engine compiler to give a more specific error message when an Ivy NgModule is imported. PR Close angular#41534
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
(though I think that may not be needed, since it's a backport)
|
Caretaker: this is a backport of #41534 to the |
|
@josephperrott what's the processes for merging into the previous major version? Would I merge this like normal using |
|
@zarend The merge tooling supports merging as normal into active LTS branches with the |
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
petebacondarwin
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
|
Closed by commit f630f33 |
…) (#41598) When an Ivy NgModule is imported into a View Engine build, it doesn't have metadata.json files that describe it as an NgModule, so it appears to VE builds as a plain, undecorated class. The error message shown in this situation generic and confusing, since it recommends adding an @NgModule annotation to a class from a library. This commit adds special detection into the View Engine compiler to give a more specific error message when an Ivy NgModule is imported. PR Close #41534 PR Close #41598
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.