feat(material/theming): Add 'base' theming dimension to all components#27924
Merged
mmalerba merged 1 commit intoangular:mainfrom Oct 11, 2023
Merged
feat(material/theming): Add 'base' theming dimension to all components#27924mmalerba merged 1 commit intoangular:mainfrom
mmalerba merged 1 commit intoangular:mainfrom
Conversation
andrewseguin
approved these changes
Oct 10, 2023
crisbeto
approved these changes
Oct 10, 2023
Adds a `base` theming dimension to go along with `color`,`typography`, and `density`. The base dimension includes styles such as border-radiuses that do not vary with the chosen color, typography, or density, but may vary depending on the theming system (e.g. Material 2 vs Material 3). BREAKING CHANGE: There are new styles emitted by `mat.<component>-theme` that are not emitted by any of: `mat.<component>-color`, `mat.<component>-typography`, or `mat.<component>-density`. If you rely on the partial mixins only and don't call `mat.<component>-theme`, you can add `mat.<component>-base` to get the missing styles. Alternatively you can call `mat.all-component-bases` to get just the base styles for all components.
965ffe7 to
4f490f5
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
basetheming dimension to go along withcolor,typography, anddensity. The base dimension includes styles such as border-radiuses that do not vary with the chosen color, typography, or density, but may vary depending on the theming system (e.g. Material 2 vs Material 3).BREAKING CHANGE:
There are new styles emitted by
mat.<component>-themethat are not emitted by any of:mat.<component>-color,mat.<component>-typography, ormat.<component>-density. If you rely on the partial mixins only and don't callmat.<component>-theme, you can addmat.<component>-baseto get the missing styles. Alternatively you can callmat.all-component-basesto get just the base styles for all components.