Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(eslint-plugin): [prefer-inject] add new rule #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2025
Merged

feat(eslint-plugin): [prefer-inject] add new rule #2461

merged 3 commits into from
May 26, 2025

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented May 26, 2025 •
edited
Loading

Closes #2165

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 26, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 1b377c9.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 41s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 48s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 1m 21s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 6s View ↗
nx run-many -t test ✅ Succeeded 31s View ↗
nx run-many -t build ✅ Succeeded 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-26 11:05:14 UTC

@JamesHenry JamesHenry changed the title fix(eslint-plugin): remove unused options feat(eslint-plugin): [prefer-inject] add new rule May 26, 2025
@codecov Codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.04878% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.83%. Comparing base (2b4e49f) to head (1b377c9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/eslint-plugin/src/rules/prefer-inject.ts 75.00% 7 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (78.04%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2461      +/-   ##
==========================================
- Coverage   92.84%   92.83%   -0.01%     
==========================================
  Files         195      197       +2     
  Lines        4093     4146      +53     
  Branches      954      971      +17     
==========================================
+ Hits         3800     3849      +49     
- Misses        226      228       +2     
- Partials       67       69       +2
Flag Coverage Δ
unittest 92.83% <78.04%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/index.ts 100.00% <100.00%> (ø)
...s/eslint-plugin/tests/rules/prefer-inject/cases.ts 100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/prefer-inject.ts 75.00% <75.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry marked this pull request as ready for review May 26, 2025 11:06
@JamesHenry JamesHenry merged commit 95c6964 into main May 26, 2025
6 of 7 checks passed
@JamesHenry JamesHenry deleted the codex/implement-prefer-inject-eslint-rule branch May 26, 2025 11:07
@JamesHenry JamesHenry mentioned this pull request May 26, 2025
Open
10 tasks
graphite-app[bot]
graphite-app bot reviewed May 26, 2025
View reviewed changes
igord pushed a commit to tcorral/angular-eslint that referenced this pull request Jun 1, 2025
@JamesHenry @igord
feat(eslint-plugin): [prefer-inject] add new rule (angular-eslint#2461)
29f33c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule Request: [prefer-inject] Prefer injecting dependencies via inject instead of constructor arguments
1 participant
@JamesHenry