-
Notifications
You must be signed in to change notification settings - Fork 286
refactor(site): gallery page support seo #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Aarebecca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the SEO capabilities of the gallery section by refactoring the detail pages to use dynamic routing and Static Site Generation (SSG). Each gallery example now has its own pre-rendered HTML page, making its content more discoverable by search engines. Additionally, the code content within these pages is made explicitly available to crawlers through a hidden HTML element. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the gallery example pages to use static generation with dynamic routes, which is a great improvement for SEO. The implementation correctly uses getStaticPaths and getStaticProps to generate individual pages for each template. My review includes a couple of suggestions for the new dynamic route page ([template].tsx) to improve robustness and add support for internationalization. Overall, this is a solid refactor that achieves its goal. Addressing the feedback will make the implementation more robust and maintainable.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great step towards improving SEO for the gallery pages by generating individual static pages for each example. The addition of a script to generate content for LLMs is also a nice touch. My review focuses on a few key areas to enhance the implementation. I've identified a potential issue with how duplicate URLs are handled in the new generation script, a non-optimal SEO practice for hiding content, and an opportunity to improve the script's performance by using asynchronous I/O. My detailed feedback is in the comments below.
llms.txtandllms-full.txtafter build site