Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: register default font and optimize isBrowser #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aarebecca merged 1 commit into from
Jan 14, 2026
Merged

fix: register default font and optimize isBrowser #166

Aarebecca merged 1 commit into from
Jan 14, 2026

Conversation

@Aarebecca
Copy link
Contributor

@Aarebecca Aarebecca commented Jan 14, 2026

fix: #157

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 14, 2026

Summary of Changes

Hello @Aarebecca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue by optimizing the isBrowser utility function for better performance and ensuring consistent default font registration. The changes streamline environment detection and guarantee that a critical font is always available, improving the robustness and efficiency of text measurement operations.

Highlights

  • Optimized isBrowser Function: The isBrowser utility function has been refactored to improve performance by caching only the true result, reducing redundant checks and streamlining environment detection.
  • Unconditional Default Font Registration: The AlibabaPuHuiTi font is now registered unconditionally, removing the previous isNode check. This ensures the default font is available across all environments where text measurement is performed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request optimizes the isBrowser utility and ensures a default font is always registered. The optimization in isBrowser now only caches a positive result, which correctly handles environments that might become browser-like over time. The change to always register the default font fixes a potential issue where text measurement could fail in non-Node, non-browser environments. My review includes suggestions to improve the naming of a variable in isBrowser for better code clarity and adherence to naming conventions.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.42%. Comparing base (d6c5066) to head (d0dc178).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   31.44%   31.42%   -0.02%     
==========================================
  Files         325      325              
  Lines       26026    26017       -9     
  Branches     1433     1433              
==========================================
- Hits         8184     8176       -8     
+ Misses      17839    17838       -1     
  Partials        3        3
Flag Coverage Δ
infographic 31.42% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/utils/is-browser.ts 94.00% <100.00%> (+1.14%) ⬆️
src/utils/measure-text.ts 31.35% <100.00%> (-1.71%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aarebecca Aarebecca merged commit 444c1df into main Jan 14, 2026
3 checks passed
@Aarebecca Aarebecca deleted the fix/font-registry branch January 14, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hustcc hustcc hustcc approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Font warning in browser environments after v0.2.5

4 participants

@Aarebecca @codecov-commenter @hustcc