fix: esm import #172
fix: esm import #172
Conversation
Aarebecca
commented
Jan 19, 2026
- fix The build artifacts are not standardized and do not conform to the Node.js ESM import specifications. #156
Summary of ChangesHello @Aarebecca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily addresses issues related to ESM module resolution and updates the internal CSS parsing mechanism. It introduces a new build step to automatically correct relative import paths in ESM bundles, which is crucial for Node.js compatibility. Additionally, it refactors the font parsing utility to use Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the ESM import issue by introducing a post-build script to add .js extensions to relative imports, which is a common and valid approach for TypeScript projects targeting ESM. Additionally, the switch from the css package to postcss for parsing font stylesheets is a great improvement, making the code more robust and modern. I have one suggestion to enhance the new script for better code clarity and robustness.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=======================================
Coverage 44.73% 44.73%
=======================================
Files 330 330
Lines 26286 26281 -5
Branches 2047 2047
=======================================
Hits 11758 11758
+ Misses 14518 14513 -5
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request aims to fix ESM import path issues by introducing tsc-alias to the build process, which is a solid approach. The changes also involve migrating from the css package to postcss for parsing font stylesheets, which is a good improvement. Overall, the changes are logical and address the intended issue. I've found one potential issue in package.json regarding cross-platform compatibility of a build script and provided a suggestion to make it more robust.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>