[ty] Isolate file-watching test environment#25151
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.36%. The percentage of expected errors that received a diagnostic held steady at 85.49%. The number of fully passing files held steady at 88/134. |
Memory usage reportMemory usage unchanged ✅ |
fc4a5d2 to
d28b4e3
Compare
d28b4e3 to
5995723
Compare
5995723 to
76abf39
Compare
|
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
## Summary The `reloading_options_updates_inferred_python_version_diagnostics_when_metadata_is_unchanged ` file watching test can fail locally when `VIRTUAL_ENV` is set. This PR improves the isolation of the file watching tests by removing known environment variables.
anishgirianish
pushed a commit
to anishgirianish/ruff
that referenced
this pull request
May 28, 2026
## Summary The `reloading_options_updates_inferred_python_version_diagnostics_when_metadata_is_unchanged ` file watching test can fail locally when `VIRTUAL_ENV` is set. This PR improves the isolation of the file watching tests by removing known environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
reloading_options_updates_inferred_python_version_diagnostics_when_metadata_is_unchangedfile watching test can fail locally whenVIRTUAL_ENVis set.This PR improves the isolation of the file watching tests by removing known environment variables.