Semantic syntax errors: better error message for global vs parameter#24902
Merged
Conversation
|
AlexWaygood
approved these changes
Apr 28, 2026
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
…stral-sh#24902) ## Summary This is an attempt to improve the error message for something like ```py a = 1 def f(a): global a ``` I realize that the previous wording ("name 'a' is parameter and global") is used by CPython itself, but unless we are trying to be consistent with CPython, I think we can improve upon this? The previous version seemed a bit cryptic to me when I first saw it. ## Test Plan Updated snapshot tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to improve the error message for something like
I realize that the previous wording ("name 'a' is parameter and global") is used by CPython itself, but unless we are trying to be consistent with CPython, I think we can improve upon this? The previous version seemed a bit cryptic to me when I first saw it.
Test Plan
Updated snapshot tests