Add a rule to flag lazy imports that are eagerly evaluated#25016
Merged
Conversation
1aa6a51 to
bcd0a05
Compare
|
6a6e68e to
cbcfe6c
Compare
ntBre
approved these changes
May 6, 2026
…port_immediately_resolved.rs Co-authored-by: Brent Westbrook <[email protected]>
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
…#25016) ## Summary This PR adds a new rule (`TID255`) to flag PEP 810 lazy imports that are resolved immediately during module import execution. For example: ```python lazy import foo class Bar(foo.Foo): ... ``` Here, `foo` is evaluated while the module is being loaded, so the import is not meaningfully lazy. We're also offering an unsafe fix to remove `lazy` when the import statement imports a single member. Closes astral-sh#25014. --------- Co-authored-by: Brent Westbrook <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new rule (
TID255) to flag PEP 810 lazy imports that are resolved immediately during module import execution.For example:
Here,
foois evaluated while the module is being loaded, so the import is not meaningfully lazy.We're also offering an unsafe fix to remove
lazywhen the import statement imports a single member.Closes #25014.