[ty] Preserve transparent callable decorators#25030
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 92.16%. The percentage of expected errors that received a diagnostic held steady at 87.31%. The number of fully passing files held steady at 92/134. |
Memory usage reportMemory usage unchanged ✅ |
|
c36d7f9 to
1ca588f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b6e2fcc to
97616f7
Compare
This was referenced Jun 5, 2026
carljm
approved these changes
Jun 5, 2026
carljm
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you! Comments could also be follow-ups.
This was referenced Jun 6, 2026
charliermarsh
pushed a commit
that referenced
this pull request
Jun 10, 2026
## Summary The workaround from #25030 only inspected function literals and direct `Callable` types. Polars types both decorators on `LazyFrame.collect` as an `IdentityFunction` protocol, so ty represented the decorator expressions as protocol instances and discarded the overload signatures. This follow-up resolves the protocol's bound `__call__` method through the existing callable upcast path, while retaining the strict `Callable[P, R] -> Callable[P, R]` signature check. Fixes the remaining Polars example reported in astral-sh/ty#2278. ## Test plan Add a regression test case for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
temporary workaround for astral-sh/ty#2278
This is a temporary fix to special case the
(arg: Callable[P, R]) -> Callable[P, R]callable which takes in a single parameter annotated as aCallable[P, R]and returns the same callable with the same type variables.This special case is ofcourse very limited because it only looks for specific
Callable[P, R]type (and a type alias that corresponds to that callable) and nothing else.Test Plan
Add a couple of test cases both for overloaded and non-overloaded function.