[ty] Fix goto-definiton for self-imported sub-modules#25106
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.36%. The percentage of expected errors that received a diagnostic held steady at 85.49%. The number of fully passing files held steady at 88/134. |
Memory usage reportMemory usage unchanged ✅ |
|
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
## Summary Fixes goto-definition for imports that self-reference the current module: `__init__.py` ```py from . import ops # can't click to go to module file from . import xyz # can't click to go to module file ``` Resolving `ops` requires resolving `.` to `__init__.py`. Go-to definition then looks for a `ops` symbol within `__init__.py`, before trying to resolve `ops` as a submodule. However, go-to def now finds the same definition again as it started from (the `ops` import from `.`), which it then tries to resolve that again. The recursion handler catches this and empty result. This PR catches this and, instead of returning an empty result, returns any available sub module Fixes astral-sh/ty#2907
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes goto-definition for imports that self-reference the current module:
__init__.pyResolving
opsrequires resolving.to__init__.py. Go-to definition then looks for aopssymbol within__init__.py, before trying to resolveopsas a submodule. However, go-to def now finds the same definition again as it started from (theopsimport from.), which it then tries to resolve that again. The recursion handler catches this and empty result.This PR catches this and, instead of returning an empty result, returns any available sub module
Fixes astral-sh/ty#2907