[ty] Only specialized types of generic class instances should influence variance#25124
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.36%. The percentage of expected errors that received a diagnostic held steady at 85.49%. The number of fully passing files held steady at 88/134. |
952f468 to
dfe8fe9
Compare
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
dfe8fe9 to
1fcd25f
Compare
oconnor663
approved these changes
May 16, 2026
| // if the class is the thing defining the variable, then it can | ||
| // reference it without it being applied to the specialization | ||
| std::iter::once(origin.variance_of(db, typevar)) | ||
| .chain( |
Contributor
There was a problem hiding this comment.
The fix makes sense to me, but I wish I understood why these lines were included in the original PR. @ericmarkmartin do you remember?
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
…ce variance (astral-sh#25124) Resolves astral-sh/ty#1459.
anishgirianish
pushed a commit
to anishgirianish/ruff
that referenced
this pull request
May 28, 2026
…ce variance (astral-sh#25124) Resolves astral-sh/ty#1459.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves astral-sh/ty#1459.