[ty] Fix panic from imported overload definition#25168
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.36%. The percentage of expected errors that received a diagnostic held steady at 85.49%. The number of fully passing files held steady at 88/134. |
Memory usage reportMemory usage unchanged ✅ |
|
9139c0c to
bdd38a7
Compare
ab87a61 to
8a16bc9
Compare
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
## Summary
Prior to this change, the post-inference overload checks could panic
when a local overload definition was shadowed by an imported overloaded
function in another branch, as in:
```python
from typing import overload
from module import f
if flag():
@overload
def a(): ...
else:
a = f
```
When checking the local `a` overload, we resolved the end-of-scope
public binding for `a` to the imported overload set for `f`. We then
tried to render those imported definitions using the current file's AST,
which tripped the panic...
We now skip the overload check when the public end-of-scope function
does not actually contain the local definition
being checked.
Closes astral-sh/ty#3462.
anishgirianish
pushed a commit
to anishgirianish/ruff
that referenced
this pull request
May 28, 2026
## Summary
Prior to this change, the post-inference overload checks could panic
when a local overload definition was shadowed by an imported overloaded
function in another branch, as in:
```python
from typing import overload
from module import f
if flag():
@overload
def a(): ...
else:
a = f
```
When checking the local `a` overload, we resolved the end-of-scope
public binding for `a` to the imported overload set for `f`. We then
tried to render those imported definitions using the current file's AST,
which tripped the panic...
We now skip the overload check when the public end-of-scope function
does not actually contain the local definition
being checked.
Closes astral-sh/ty#3462.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this change, the post-inference overload checks could panic when a local overload definition was shadowed by an imported overloaded function in another branch, as in:
When checking the local
aoverload, we resolved the end-of-scope public binding forato the imported overload set forf. We then tried to render those imported definitions using the current file's AST, which tripped the panic...We now skip the overload check when the public end-of-scope function does not actually contain the local definition
being checked.
Closes astral-sh/ty#3462.