[ty] Add error context for extra callable parameters#25269
Merged
Conversation
d0a51a1 to
041b8ae
Compare
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.36%. The percentage of expected errors that received a diagnostic held steady at 85.49%. The number of fully passing files held steady at 88/134. |
Memory usage reportMemory usage unchanged ✅ |
|
| } | ||
| Self::ExtraRequiredParameter { parameter } => match parameter { | ||
| ParameterDescription::Named(name) => format!("unexpected extra parameter `{name}`"), | ||
| ParameterDescription::Index(_) => "unexpected extra parameter".to_string(), |
Member
There was a problem hiding this comment.
Option<Cow<...>> :)
(I assume you will reject this feedback lol)
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
## Summary In an invalid assignment like the following ... ```py def source(x: int, extra: str) -> bool: ... target: Callable[[int], bool] = source ``` ... we now add a new error context hint (last line): ``` error[invalid-assignment]: Object of type `def source(x: int, extra: str) -> bool` is not assignable to `(int, /) -> bool` --> src/mdtest_snippet.py:16:9 | 16 | target: Callable[[int], bool] = source # snapshot | --------------------- ^^^^^^ Incompatible value of type `def source(x: int, extra: str) -> bool` | | | Declared type | info: unexpected extra parameter `extra` ``` ## Test Plan New Markdown test
anishgirianish
pushed a commit
to anishgirianish/ruff
that referenced
this pull request
May 28, 2026
## Summary In an invalid assignment like the following ... ```py def source(x: int, extra: str) -> bool: ... target: Callable[[int], bool] = source ``` ... we now add a new error context hint (last line): ``` error[invalid-assignment]: Object of type `def source(x: int, extra: str) -> bool` is not assignable to `(int, /) -> bool` --> src/mdtest_snippet.py:16:9 | 16 | target: Callable[[int], bool] = source # snapshot | --------------------- ^^^^^^ Incompatible value of type `def source(x: int, extra: str) -> bool` | | | Declared type | info: unexpected extra parameter `extra` ``` ## Test Plan New Markdown test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In an invalid assignment like the following ...
... we now add a new error context hint (last line):
Test Plan
New Markdown test