Codestin Search App

mhuen · 2026-05-23T07:49:04Z

Summary

Adds support for LSP call hierarchy calls including:

textDocument/prepareCallHierarchy
callHierarchy/incoming
callHierarchy/outgoing

Closes astral-sh/ty#1976

Test Plan

unit tests added in crates/ty_ide/src/call_hierarchy.rs
basic e2e tests in crates/ty_server/tests/e2e/call_hierarchy.rs
manual cross-checks against pyright (see known differences below)
criterion benchmark for e2e performance on anyio

Known differences to pyright (version 1.1.408)

Class outgoing uses class-statement semantics
- ty includes class decorators, base-class expressions, body calls, method decorators, parameter defaults
- ty excludes method bodies, nested function bodies, lambda bodies
- Pyright walks __init__'s body instead; reports nothing for classes without __init__
Function outgoing stops at nested def/class/lambda bodies
- ty reports the nested name as a callee, not the calls inside its body
- Pyright walks into nested defs
- Symmetry with the class-outgoing behavior above
super().__init__() incoming reported once
- ty deduplicates by (file, caller selection range)
- Pyright reports the same range twice
@property dispatched by access kind
- Read (c.prop) matches getter only; write (c.prop = v) matches setter only; del (del c.prop) matches deleter only
- Pyright lumps every read/write/del under getter+setter+deleter
- Models Python's descriptor protocol more faithfully
Caller kind reflects the real symbol kind
- ty emits Method (6), Class (5), or Function (12) based on the caller's enclosing scope
- Pyright always emits Function (12) regardless of caller type
Aliased-import call sites resolve through the alias
- from x import f as g; g() reports as a caller of f
- Pyright misses the alias and returns incomingCalls: null

MichaReiser · 2026-05-23T16:02:25Z

Wow, nice! I agree, this is a feature that ty desperately needs and it's on our immediate roadmap. However, it may take us 1-2 weeks before I'll have a chance to review this, as there is one more fatal panic that I want to look into first.

From skimming this code (and without having a concrete idea on how this should or is working in the PR), these are a few questions/comments that popped up:

The parsed module cache is probably unnecessary. parsed_module is already cached, calling it should be very cheap (roughly as expensive as a hash map lookup)
Can we reuse more code with find references?

mhuen · 2026-05-27T06:10:15Z

@MichaReiser thanks for the initial feedback. No worries on the timeline, I am not in a rush.
You're right about the unnecessary parsed module cache. I have removed that and also the local duplicate is_dunder helper along with some other cleanup.
Let me know if this PR is salvageable. I don't usually program in Rust, nor am I familiar with the code base. I'm happy to address issues here, but also fine in case it's easier for you to implement this from scratch.

astral-sh-bot · 2026-05-27T07:13:37Z

Typing conformance results

No changes detected ✅

Current numbers

The percentage of diagnostics emitted that were expected errors held steady at 91.94%. The percentage of expected errors that received a diagnostic held steady at 87.09%. The number of fully passing files held steady at 92/134.

astral-sh-bot · 2026-05-27T07:14:36Z

Memory usage report

Memory usage unchanged ✅

astral-sh-bot · 2026-05-27T07:16:49Z

`ecosystem-analyzer` results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

astral-sh-bot · 2026-05-27T07:34:42Z

`ruff-ecosystem` results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -2 violations, +0 -0 fixes in 1 projects; 55 projects unchanged)

zulip/zulip (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --no-preview --select ALL

- zproject/prod_settings_template.py:297:1: ERA001 Found commented-out code
- zproject/prod_settings_template.py:298:1: ERA001 Found commented-out code

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
ERA001	2	0	2	0	0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -2 violations, +0 -0 fixes in 1 projects; 55 projects unchanged)

zulip/zulip (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

- zproject/prod_settings_template.py:297:1: ERA001 Found commented-out code
- zproject/prod_settings_template.py:298:1: ERA001 Found commented-out code

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
ERA001	2	0	2	0	0

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

ruff format --preview --exclude examples/mcp/databricks_mcp_cookbook.ipynb,examples/chatgpt/gpt_actions_library/gpt_action_google_drive.ipynb,examples/chatgpt/gpt_actions_library/gpt_action_redshift.ipynb,examples/chatgpt/gpt_actions_library/gpt_action_salesforce.ipynb,

warning: Detected debug build without --no-cache.
error: Encountered error: No such file or directory (os error 2)

MichaReiser · 2026-05-28T10:05:47Z

+
+/// Helper for `callHierarchy/incomingCalls`. Iterates over all projects in the
+/// session and merges results from whichever project owns the file.
+pub(crate) fn incoming_calls_handler(


I'd move this into the incoming call request handler's file. Given that it's not used elsewhere

MichaReiser · 2026-05-28T10:05:53Z

+/// Helper for `callHierarchy/outgoingCalls`. Same multi-project iteration as
+/// the incoming variant, but `from_ranges` come from the *prepared* item's
+/// file (the caller).
+pub(crate) fn outgoing_calls_handler(


MichaReiser · 2026-05-28T10:11:28Z

+    sites
+}
+
+struct CallSitesFinder<'a, 'db> {


Can you say more why this is an entirely new visitor. Could we use LocalReferencesFinder instead and either trim the results afterwards or have a mode parameter to drop references we don't care about?

MichaReiser · 2026-05-28T10:11:54Z

+}
+
+/// AST visitor that, for a single function/class body, records every callee.
+struct OutgoingCallsFinder<'a, 'db> {


Same here. Could we reuse some of LocalReferencesFinder

MichaReiser · 2026-05-28T18:25:12Z

This is awesome. Thank you! I did a few changes, mainly to how the test work and I split the implementation into multiple modules. I'll also remove the benchmark. While cool, I'm worried that it's noisy

codspeed-hq · 2026-05-28T19:49:35Z

Merging this PR will degrade performance by 4.38%

❌ 1 regressed benchmark
✅ 64 untouched benchmarks
⏩ 60 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	WallTime	`pydantic`	34.7 s	36.3 s	-4.38%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing mhuen:mhuen/ty-call-hierarchy-optimizations (01782de) with main (320a482)}

60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Co-authored-by: Micha Reiser <[email protected]>

mhuennefeld · 2026-05-28T21:43:09Z

Awesome thanks! Yes, the benchmark wasn't terribly helpful. Great, thanks for the time spent reviewing and updating the code. Do you have a rough timeline for a next release candidate of ty that will include this?

MichaReiser · 2026-05-29T07:00:35Z

Do you have a rough timeline for a next release candidate of ty that will include this?

We do very frequent releases. It should go out in the next few days

thernstig · 2026-05-29T12:19:17Z

@mhuen could you update https://docs.astral.sh/ty/features/language-server/#feature-reference? Similar to what was done in https://github.com/astral-sh/ty/pull/3382/changes.

You need to add textDocument/prepareCallHierarchy as well as I did not see it there.

Great job.

mhuen · 2026-05-29T22:02:25Z

@mhuen could you update https://docs.astral.sh/ty/features/language-server/#feature-reference? Similar to what was done in https://github.com/astral-sh/ty/pull/3382/changes.

You need to add textDocument/prepareCallHierarchy as well as I did not see it there.

Great job.

I had opened astral-sh/ty#3592, but as @MichaReiser points out, it may not be necessary

mhuen added 4 commits May 23, 2026 01:49

[ty] Add call hierarchy support

0ddc77f

[ty] Optimize incoming call hierarchy by filtering candidate sites

723769d

[ty] Optimize prepare/outgoing call hierarchy by skipping redundant work

653a60d

[ty] Add call hierarchy performance benchmark

185e122

mhuen requested review from AlexWaygood, BurntSushi, Gankra, MichaReiser, carljm, dcreager and sharkdp as code owners May 23, 2026 07:49

astral-sh-bot Bot assigned MichaReiser May 23, 2026

mhuen mentioned this pull request May 23, 2026

LSP: Support callHierarchy/incomingCalls and callHierarchy/outgoingCalls astral-sh/ty#1976

Closed

MichaReiser added server Related to the LSP server ty Multi-file analysis & type inference labels May 23, 2026

mhuen added 3 commits May 27, 2026 04:09

[ty] Remove redundant parsed_module cache

ff15bfb

[ty] use existing is_dunder helper

8f3ecc8

[ty] Reuse PropertyInstanceType for property-accessor classification

b7662ac

mhuen requested a review from ibraheemdev as a code owner May 27, 2026 06:04

[ty] ignore benchmark-only deps in cargo shear

0608862

AlexWaygood removed their request for review May 27, 2026 17:53

MichaReiser reviewed May 28, 2026

View reviewed changes

Move code around

743bb76

MichaReiser added 10 commits May 28, 2026 14:27

Use SymbolKind

6591d7c

Share function classification with workspace symbols

57da400

Use snapshot tests for incoming calls

99c6ac4

Use snapshot tests for outgoing calls

85fb95d

Refine incoming/outgoing snapshots

ba90753

Use snapshots for prepare call hierarchy, deduplicate definitions

d201a06

Small nits when reviewing call hierarchy

2fed90f

Nits while reviewing outgoing_calls

d442fad

Nits while reviewing incoming_calls

ff12487

Nits in server code

23a694c

MichaReiser added 3 commits May 28, 2026 20:25

Show module name in details

6d80526

Remove benchmark

eaa0778

Don't consider attribute access as method call

01782de

MichaReiser enabled auto-merge (squash) May 28, 2026 18:54

MichaReiser merged commit f9ba228 into astral-sh:main May 28, 2026
58 of 59 checks passed

anishgirianish pushed a commit to anishgirianish/ruff that referenced this pull request May 28, 2026

[ty] Add call hierarchy support (astral-sh#25338)

11bf0a0

Co-authored-by: Micha Reiser <[email protected]>

mhuen mentioned this pull request May 29, 2026

Document support for textDocument/prepareCallHierarchy and textDocument/prepareTypeHierarchy astral-sh/ty#3592

Closed

Uh oh!

Conversation

mhuen commented May 23, 2026 • edited by MichaReiser Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Known differences to pyright (version 1.1.408)

Uh oh!

MichaReiser commented May 23, 2026

Uh oh!

mhuen commented May 27, 2026

Uh oh!

astral-sh-bot Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Typing conformance results

No changes detected ✅

Uh oh!

astral-sh-bot Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Memory usage report

Uh oh!

astral-sh-bot Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ecosystem-analyzer results

Uh oh!

astral-sh-bot Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Formatter (stable)

Formatter (preview)

Uh oh!

MichaReiser May 28, 2026

Choose a reason for hiding this comment

Uh oh!

MichaReiser May 28, 2026

Choose a reason for hiding this comment

Uh oh!

MichaReiser May 28, 2026

Choose a reason for hiding this comment

Uh oh!

MichaReiser May 28, 2026

Choose a reason for hiding this comment

Uh oh!

MichaReiser commented May 28, 2026

Uh oh!

Uh oh!

codspeed-hq Bot commented May 28, 2026

Merging this PR will degrade performance by 4.38%

Performance Changes

Footnotes

Uh oh!

mhuennefeld commented May 28, 2026

Uh oh!

MichaReiser commented May 29, 2026

Uh oh!

thernstig commented May 29, 2026

Uh oh!

mhuen commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mhuen commented May 23, 2026 •

edited by MichaReiser

Loading

astral-sh-bot Bot commented May 27, 2026 •

edited

Loading

astral-sh-bot Bot commented May 27, 2026 •

edited

Loading

astral-sh-bot Bot commented May 27, 2026 •

edited

Loading

`ecosystem-analyzer` results

astral-sh-bot Bot commented May 27, 2026 •

edited

Loading

`ruff-ecosystem` results