[ty] Reject inconsistent generic bases in dynamic classes#25413
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.70%. The percentage of expected errors that received a diagnostic held steady at 86.99%. The number of fully passing files held steady at 91/134. |
Memory usage reportMemory usage unchanged ✅ |
1773e57 to
8dd2f23
Compare
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-argument-type |
0 | 4 | 12 |
| Total | 0 | 4 | 12 |
Raw diff (16 changes)
Expression (https://github.com/cognitedata/Expression)
- expression/collections/maptree.py:113:25 error[invalid-argument-type] Argument to function `mk` is incorrect: Argument type `Key@rebalance | Value@rebalance` does not satisfy upper bound `SupportsLessThan` of type variable `Key`
+ expression/collections/maptree.py:113:25 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, object]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`
- expression/collections/maptree.py:113:25 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, object]]`, found `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`
+ expression/collections/maptree.py:113:28 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance]]`
- expression/collections/maptree.py:113:28 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance]]`
+ expression/collections/maptree.py:113:38 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`, found `Option[MapTreeLeaf[Never, Never]]`
- expression/collections/maptree.py:113:38 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`, found `Option[MapTreeLeaf[Never, Never]]`
- expression/collections/maptree.py:121:27 error[invalid-argument-type] Argument to function `mk` is incorrect: Argument type `Key@rebalance | Value@rebalance` does not satisfy upper bound `SupportsLessThan` of type variable `Key`
+ expression/collections/maptree.py:121:27 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, object]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`
- expression/collections/maptree.py:121:27 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, object]]`, found `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`
+ expression/collections/maptree.py:121:30 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance]]`
- expression/collections/maptree.py:121:30 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance]]`
+ expression/collections/maptree.py:121:40 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`, found `Option[MapTreeLeaf[Never, Never]]`
- expression/collections/maptree.py:121:40 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`, found `Option[MapTreeLeaf[Never, Never]]`
- expression/collections/maptree.py:136:29 error[invalid-argument-type] Argument to function `mk` is incorrect: Argument type `Key@rebalance | Value@rebalance` does not satisfy upper bound `SupportsLessThan` of type variable `Key`
+ expression/collections/maptree.py:136:29 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, object]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`
- expression/collections/maptree.py:136:29 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, object]]`, found `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`
+ expression/collections/maptree.py:136:32 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`, found `Option[MapTreeLeaf[Never, Never]]`
- expression/collections/maptree.py:136:32 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`, found `Option[MapTreeLeaf[Never, Never]]`
+ expression/collections/maptree.py:136:49 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance]]`
- expression/collections/maptree.py:136:49 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance]]`
- expression/collections/maptree.py:141:61 error[invalid-argument-type] Argument to function `mk` is incorrect: Argument type `Key@rebalance | Value@rebalance` does not satisfy upper bound `SupportsLessThan` of type variable `Key`
+ expression/collections/maptree.py:141:61 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, object]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`
- expression/collections/maptree.py:141:61 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, object]]`, found `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`
+ expression/collections/maptree.py:141:64 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`, found `Option[MapTreeLeaf[Never, Never]]`
- expression/collections/maptree.py:141:64 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`, found `Option[MapTreeLeaf[Never, Never]]`
+ expression/collections/maptree.py:141:81 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance, Value@rebalance | Key@rebalance]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance]]`
- expression/collections/maptree.py:141:81 error[invalid-argument-type] Argument to function `mk` is incorrect: Expected `Option[MapTreeLeaf[Key@rebalance | Value@rebalance, Value@rebalance]]`, found `Option[MapTreeLeaf[Key@rebalance, Value@rebalance]]`
anishgirianish
pushed a commit
to anishgirianish/ruff
that referenced
this pull request
May 28, 2026
…25413) ## Summary We do this for static classes, but were missing the analysis for dynamic classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We do this for static classes, but were missing the analysis for dynamic classes.