[ty] Avoid panic for deferred dataclass field annotations#25444
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 91.94%. The percentage of expected errors that received a diagnostic held steady at 87.09%. The number of fully passing files held steady at 92/134. |
Memory usage reportMemory usage unchanged ✅ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I fixed astral-sh/ty#3493 in #25249, but missed the case of deferred evaluation for annotations... For deferred evaluation, when we then checked whether that field was a descriptor,
class_member_with_policyattempted meta-type lookup on the cycle marker itself and panicked.E.g., on Python 3.14, where annotations are deferred by default:
We now apply the materialized divergent fallback before class-member lookup, consistent with the other lookup and descriptor operations. (The example reports the expected missing argument for
ainstead of panicking, and is covered under Python 3.14.)Closes astral-sh/ty#3493.