[ty] Compact retained semantic arrays#25454
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 91.94%. The percentage of expected errors that received a diagnostic held steady at 87.09%. The number of fully passing files held steady at 92/134. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
|
0bfc0d5 to
55b7221
Compare
55b7221 to
bedff0d
Compare
AlexWaygood
approved these changes
May 29, 2026
bedff0d to
7982353
Compare
7982353 to
0d442ad
Compare
MichaReiser
reviewed
May 29, 2026
| impl<K: Ord, V> FromIterator<(K, V)> for FrozenMap<K, V> { | ||
| fn from_iter<T: IntoIterator<Item = (K, V)>>(iter: T) -> Self { | ||
| let mut entries = iter.into_iter().collect::<Vec<_>>(); | ||
| entries.sort_unstable_by(|(left, _), (right, _)| left.cmp(right)); |
Member
There was a problem hiding this comment.
Have you considered storing a keys and values Box? Would this make searching faster (because it needs to eat through less memory)
Member
There was a problem hiding this comment.
Feel free to do this in a separate PR. It may also not be that impactful, given that the keys and values are all small types
MichaReiser
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces the memory retained by Salsa-cached semantic indexes by using a
FrozenIndexVecfor index-addressed immutable arrays, like theFrozenMapabstraction.Apart from a >1% memory reduction, we see a 1% improvement on
attrs,anyio,hydra-zen,multithreaded; 1% regression onpydanticandfreqtrade.