[ty] Add missing-type-argument lint rule#25617
Merged
JelleZijlstra merged 9 commits intoJun 5, 2026
Merged
Conversation
Add a new lint that detects generic types used without explicit type
parameters in annotations (e.g. `list` instead of `list[int]`).
This is equivalent to mypy's `--disallow-any-generics` and pyright's
`reportMissingTypeArgument`.
The rule defaults to `Level::Ignore` (opt-in) and can be enabled via:
[rules]
missing-type-argument = "warn"
It skips classes where all type parameters have PEP 696 defaults.
Added tests covering stdlib generics, user-defined generics, PEP 696
defaults, dotted names, function signatures, and variable annotations.
jelle-openai
reviewed
Jun 3, 2026
jelle-openai
reviewed
Jun 3, 2026
…s, and base classes
reginaldl
commented
Jun 4, 2026
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 92.16%. The percentage of expected errors that received a diagnostic held steady at 87.31%. The number of fully passing files held steady at 92/134. |
Memory usage reportMemory usage unchanged ✅ |
|
…ion.rs Co-authored-by: Jelle Zijlstra <[email protected]>
jelle-openai
reviewed
Jun 4, 2026
jelle-openai
reviewed
Jun 4, 2026
jelle-openai
reviewed
Jun 4, 2026
MichaReiser
reviewed
Jun 5, 2026
JelleZijlstra
approved these changes
Jun 5, 2026
JelleZijlstra
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! I pushed a few followups. I'll wait for CI to run and if everything looks good I'll merge this.
Contributor
Author
I wondered why I was getting conflicts trying to address feedback 😂 |
Collaborator
|
Sorry for that! I think it's pretty much ready now, I had to fix up a few more CI issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new lint that detects generic types used without explicit type parameters in annotations (e.g.
listinstead oflist[int]).This is equivalent to mypy's
--disallow-any-genericsand pyright'sreportMissingTypeArgument.Can be enabled via:
It skips classes where all type parameters have PEP 696 defaults.
This should fix the following issue in ty:
Unknown-specialized types used in annotations ty#2442Test Plan
Added tests covering stdlib generics, user-defined generics, PEP 696 defaults, dotted names, function signatures, and variable annotations.