[ty] Avoid caching trivial member lookups#25661
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 92.13%. The percentage of expected errors that received a diagnostic held steady at 87.18%. The number of fully passing files held steady at 92/134. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
AlexWaygood
approved these changes
Jun 5, 2026
| heap_size=ruff_memory_usage::heap_size | ||
| )] | ||
| pub(crate) fn member_lookup_with_policy( | ||
| fn member_lookup_with_policy_inner( |
Member
There was a problem hiding this comment.
if there's no valid reason for this function ever to be called outside of its single callsite, I would make it a nested function inside member_lookup_with_policy, and remove the special case regarding __class__ from the body of the function. (The special case is now handled by the wrapper function that calls it.)
Member
Author
There was a problem hiding this comment.
I'm a bit mixed on whether this is worth the churn (though I'll remove the special-case).
Member
There was a problem hiding this comment.
personaly I think so -- it's what we do in a bunch of other places where we have similar situations. the fact that there's an inner Salsa-tracked function that's wrapped by an outer non-tracked function is an implementation detail that callers shouldn't have to worry about and that shouldn't impact the autocomplete suggestions I get in VSCode, etc
charliermarsh
added a commit
that referenced
this pull request
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
member_lookup_with_policycurrently creates and retains a Salsa query even when the result is known before attribute lookup: for__class__, and for dynamic, divergent, andNevertypes.This change handles those cases before entering the tracked query. Materialized divergent fallbacks and the existing
__class__ordering are preserved; all other lookups continue through the unchanged tracked implementation.