You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FunctionType currently stores its optional updated callable signature and optional updated implementation signature inline. Ordinary function types have neither, but every interned value still reserves space for both.
This groups the uncommon updated signatures into one boxed payload. Ordinary function types retain only the function literal and an empty optional pointer; specialized function types pay at most one allocation and continue to expose the same signatures.
On a representative package, this reduced retained FunctionType memory by 56% and total retained memory by 1.05 MB (0.35%). A ten-run isolated comparison showed no runtime regression.
Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 92.16%. The percentage of expected errors that received a diagnostic held steady at 87.31%. The number of fully passing files held steady at 92/134.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FunctionTypecurrently stores its optional updated callable signature and optional updated implementation signature inline. Ordinary function types have neither, but every interned value still reserves space for both.This groups the uncommon updated signatures into one boxed payload. Ordinary function types retain only the function literal and an empty optional pointer; specialized function types pay at most one allocation and continue to expose the same signatures.
On a representative package, this reduced retained
FunctionTypememory by 56% and total retained memory by 1.05 MB (0.35%). A ten-run isolated comparison showed no runtime regression.