[ty] Compact retained use-def bindings#25682
Merged
charliermarsh merged 5 commits intoJun 6, 2026
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 92.16%. The percentage of expected errors that received a diagnostic held steady at 87.31%. The number of fully passing files held steady at 92/134. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
AlexWaygood
approved these changes
Jun 6, 2026
31223fc to
7148fb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UseDefMapcurrently retains every interned binding state as aSmallVec, including builder-only capacity and an optional unbound constraint that are no longer needed after semantic indexing finishes.This change packs the shadowing policy into the scope-local definition ID and stores retained binding states as ranges into one contiguous
LiveBindingarray. Binding construction and interning behavior remain unchanged, while eachLiveBindingshrinks from 16 to 12 bytes and retained states no longer carry per-vector allocation metadata.On a large codebase, this reduced retained memory by 2.96% without a wall-time regression.