[ty] Avoid caching trivial class-header queries#25692
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 92.16%. The percentage of expected errors that received a diagnostic held steady at 87.31%. The number of fully passing files held steady at 92/134. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
Merging this PR will improve performance by 7.71%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | ty_micro[large_union_narrowing] |
332.5 ms | 308.7 ms | +7.71% |
Tip
Curious why this is faster? Use the CodSpeed MCP and ask your agent.
Comparing charlie/avoid-caching-trivial-class-headers (a6d3142) with main (3e70e4a)
Footnotes
-
60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
6257a4b to
d20901b
Compare
d20901b to
a6d3142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StaticClassLiteralcurrently creates and retains Salsa queries for explicit bases, inherited generic contexts,TypedDictdetection, metaclass resolution, inheritance-cycle detection, and code-generator classification even when a class header has no bases or explicit metaclass.This records whether those syntax forms are present when constructing the class literal and returns the trivial result before entering the tracked query when they are absent. Classes with bases or explicit metaclasses continue through the existing tracked implementations.
On a large codebase, this reduced retained memory from 93.03 GB to 91.54 GB, saving 1.49 GB (1.60%) on top of the decorator and type-parameter fast paths from #25689, without a runtime regression.