You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
from module import name import inference already knows that the left-hand side resolved to a module literal, but it still routed the final attribute lookup through the generic Type::member path. That path handles arbitrary receiver types and descriptor behavior before eventually reaching module lookup.
This constructs the ModuleLiteralType directly, reuses it for the existing self-referential global-import guard, and calls ModuleLiteralType::static_member when checking whether the imported module exports the requested name. Import semantics stay the same, while module import lookup avoids the generic member-lookup machinery.
The now-unused Type::as_module_literal helper is removed.
Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 92.16%. The percentage of expected errors that received a diagnostic held steady at 87.31%. The number of fully passing files held steady at 92/134.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
performancePotential performance improvementtyMulti-file analysis & type inference
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from module import nameimport inference already knows that the left-hand side resolved to a module literal, but it still routed the final attribute lookup through the genericType::memberpath. That path handles arbitrary receiver types and descriptor behavior before eventually reaching module lookup.This constructs the
ModuleLiteralTypedirectly, reuses it for the existing self-referential global-import guard, and callsModuleLiteralType::static_memberwhen checking whether the imported module exports the requested name. Import semantics stay the same, while module import lookup avoids the generic member-lookup machinery.The now-unused
Type::as_module_literalhelper is removed.