You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DefinitionInference almost always retains either one binding, one declaration, or a binding and declaration for the same definition and type. DefinitionTypes stored each of these common cases in a separate Box, adding a heap allocation for every cached result, while only the uncommon multi-result case needs out-of-line storage.
This stores the common singleton payloads directly in the enum and keeps the Other variant boxed. The cycle-normalization and iteration paths preserve the existing behavior while operating on the inline payloads.
On a representative project, this reduced retained memory from 287,972,361 bytes to 286,861,193 bytes, saving 1,111,168 bytes (0.39%) without diagnostic changes.
Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 92.23%. The percentage of expected errors that received a diagnostic held steady at 87.42%. The number of fully passing files held steady at 92/134.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
performancePotential performance improvementtyMulti-file analysis & type inference
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefinitionInferencealmost always retains either one binding, one declaration, or a binding and declaration for the same definition and type.DefinitionTypesstored each of these common cases in a separateBox, adding a heap allocation for every cached result, while only the uncommon multi-result case needs out-of-line storage.This stores the common singleton payloads directly in the enum and keeps the
Othervariant boxed. The cycle-normalization and iteration paths preserve the existing behavior while operating on the inline payloads.On a representative project, this reduced retained memory from 287,972,361 bytes to 286,861,193 bytes, saving 1,111,168 bytes (0.39%) without diagnostic changes.