[ty] Avoid resolving overload sets for ordinary functions#25817
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 92.23%. The percentage of expected errors that received a diagnostic held steady at 87.42%. The number of fully passing files held steady at 92/134. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
Merging this PR will improve performance by 9.85%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | ty_micro[typevar_mapping_small_accumulations] |
216.3 ms | 196.9 ms | +9.85% |
Tip
Curious why this is faster? Use the CodSpeed MCP and ask your agent.
Comparing charlie/fast-path-non-overloaded-functions (70ff9c0) with main (13e4a58)
Footnotes
-
60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
69e7908 to
0cfb21c
Compare
37ef30f to
ca6f7e9
Compare
ca6f7e9 to
70ff9c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FunctionLiteralcurrently resolves its overload chain through a tracked query whenever callers need its definitions or callable signature, even though most functions consist of one ordinary definition.This records the common no-overload case when constructing the function literal and returns the empty overload set plus the last definition before entering the tracked collector. Definition iteration and signature construction reuse that shared result, while functions with overloads continue through the existing tracked implementation.