[ty] Respect @no_type_check in function validation#25994
Merged
charliermarsh merged 1 commit intoJun 14, 2026
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.36%. The percentage of expected errors that received a diagnostic held steady at 88.82%. The number of fully passing files held steady at 93/134. |
Memory usage reportMemory usage unchanged ✅ |
|
Member
Author
|
Merging this directly; we already respect this in function bodies, this looks like an oversight. |
Member
|
Nice, thanks, definitely an oversight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@no_type_checkpromises to suppress errors in a function declaration and body, but diagnostics emitted during post-inference function validation were not suppressed:Post-inference validation runs from the function's enclosing inference context, so the decorated function is not visible through the usual ancestor-scope suppression check. This returns before running those declaration checks when the function itself has a known
@no_type_checkdecorator.