[ty] Highlight decorated methods consistently#26003
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.36%. The percentage of expected errors that received a diagnostic held steady at 88.91%. The number of fully passing files held steady at 93/134. |
Memory usage reportMemory usage unchanged ✅ |
|
AlexWaygood
approved these changes
Jun 15, 2026
Comment on lines
+2151
to
+2153
| @classmethod | ||
| @decorate | ||
| def class_method(cls) -> None: ... |
Member
There was a problem hiding this comment.
you could possibly also add tests with these in the other order too, e.g.
@decorate
@classmethod
def class_method(cls) -> None: ...
Member
Author
There was a problem hiding this comment.
It seems that we already test this add the ty_python_semantic level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Highlight function-like callable attributes as methods while leaving regular callable attributes unchanged.
Fixes astral-sh/ty#3771.
Test plan
Added integration test