You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Keep the large per-scope use-def builders boxed so outer index growth only moves pointers. This removes about 5.2 MB of allocation and copy churn on attrs without adding allocations for the smaller place-table builders.
Performance
This is 2-3% perf improvements on our benchmarks.
Test Plan
Testing: Passed ty_python_core tests, Clippy, and repository hooks.
Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 94.37%. The percentage of expected errors that received a diagnostic held steady at 89.00%. The number of fully passing files held steady at 94/134.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
performancePotential performance improvementtyMulti-file analysis & type inference
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the large per-scope use-def builders boxed so outer index growth only moves pointers. This removes about 5.2 MB of allocation and copy churn on attrs without adding allocations for the smaller place-table builders.
Performance
This is 2-3% perf improvements on our benchmarks.
Test Plan
Testing: Passed ty_python_core tests, Clippy, and repository hooks.