Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ty] Avoid moving boxed use-def map builders#26211

Merged
MichaReiser merged 1 commit into
mainfrom
micha/avoid-use-def-map-builder-moves
Jun 22, 2026
Merged

[ty] Avoid moving boxed use-def map builders#26211
MichaReiser merged 1 commit into
mainfrom
micha/avoid-use-def-map-builder-moves

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Jun 22, 2026

Copy link
Copy Markdown
Member

Consume UseDefMapBuilder through its Box so finalization does not first move the builder onto the stack. This removes two copies per scope; DHAT measured 2.8 MB fewer copies on DateType and 7.4 MB on hydra-zen, with neutral heap usage and runtime.

@astral-sh-bot astral-sh-bot Bot added the ty Multi-file analysis & type inference label Jun 22, 2026
@astral-sh-bot

astral-sh-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 94.37%. The percentage of expected errors that received a diagnostic held steady at 89.00%. The number of fully passing files held steady at 94/134.

@astral-sh-bot

astral-sh-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Memory usage report

Summary

Project Old New Diff Outcome
trio 78.59MB 78.60MB +0.01% (10.52kB)
sphinx 195.79MB 195.80MB +0.00% (1.50kB)
prefect 524.25MB 524.25MB +0.00% (536.00B)
flake8 31.36MB 31.35MB -0.01% (3.37kB) ⬇️

Significant changes

Click to expand detailed breakdown

trio

Name Old New Diff Outcome
parsed_module 15.04MB 15.05MB +0.07% (10.52kB)

sphinx

Name Old New Diff Outcome
parsed_module 18.36MB 18.36MB +0.01% (1.50kB)

prefect

Name Old New Diff Outcome
parsed_module 19.36MB 19.36MB +0.00% (536.00B)

flake8

Name Old New Diff Outcome
parsed_module 9.77MB 9.77MB -0.03% (3.37kB) ⬇️

@astral-sh-bot

astral-sh-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@MichaReiser MichaReiser marked this pull request as ready for review June 22, 2026 09:15
@MichaReiser MichaReiser requested a review from a team as a code owner June 22, 2026 09:15
@astral-sh-bot astral-sh-bot Bot requested a review from charliermarsh June 22, 2026 09:15
@MichaReiser MichaReiser merged commit 84dc6c0 into main Jun 22, 2026
60 checks passed
@MichaReiser MichaReiser deleted the micha/avoid-use-def-map-builder-moves branch June 22, 2026 09:15
@MichaReiser MichaReiser added the performance Potential performance improvement label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Potential performance improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant