Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ty] Reuse the first union bindings buffer#26225

Merged
charliermarsh merged 5 commits into
mainfrom
micha/reuse-bindings-union-buffer
Jun 22, 2026
Merged

[ty] Reuse the first union bindings buffer#26225
charliermarsh merged 5 commits into
mainfrom
micha/reuse-bindings-union-buffer

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Avoid allocating a new SmallVec when unioning Bindings. Instead, reuse the first element's buffer.

Benchmark

A 1-3% performance improvement on most walltime projects.

@astral-sh-bot astral-sh-bot Bot added the ty Multi-file analysis & type inference label Jun 22, 2026
@astral-sh-bot

astral-sh-bot Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 94.37%. The percentage of expected errors that received a diagnostic held steady at 89.00%. The number of fully passing files held steady at 94/134.

@astral-sh-bot

astral-sh-bot Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Memory usage report

Summary

Project Old New Diff Outcome
flake8 30.82MB 30.83MB +0.02% (7.80kB) ⏫
trio 77.56MB 77.56MB +0.00% (2.45kB) ⏫
sphinx 193.94MB 193.94MB +0.00% (1.72kB) ⏫
prefect 518.49MB 518.48MB -0.00% (13.52kB) ⬇️

Significant changes

Click to expand detailed breakdown

flake8

Name Old New Diff Outcome
parsed_module 9.77MB 9.78MB +0.08% (7.80kB) ⏫

trio

Name Old New Diff Outcome
parsed_module 15.04MB 15.04MB +0.02% (2.45kB) ⏫

sphinx

Name Old New Diff Outcome
parsed_module 18.36MB 18.36MB +0.01% (1.72kB) ⏫

prefect

Name Old New Diff Outcome
parsed_module 19.36MB 19.35MB -0.07% (13.52kB) ⬇️

@astral-sh-bot

astral-sh-bot Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@MichaReiser MichaReiser marked this pull request as ready for review June 22, 2026 16:01
@MichaReiser MichaReiser requested a review from a team as a code owner June 22, 2026 16:01
@astral-sh-bot astral-sh-bot Bot requested a review from dcreager June 22, 2026 16:01
@charliermarsh charliermarsh merged commit 2126e5f into main Jun 22, 2026
60 checks passed
@charliermarsh charliermarsh deleted the micha/reuse-bindings-union-buffer branch June 22, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes
@dcreager dcreager Awaiting requested review from dcreager

Assignees

No one assigned

Labels

ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaReiser @charliermarsh