[ty] Defer applying type context to simple standalone expressions#26252
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.37%. The percentage of expected errors that received a diagnostic held steady at 89.00%. The number of fully passing files held steady at 94/134. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
Member
Author
|
Looks like a small performance and memory usage win across the board. I have some future PRs built upon the |
charliermarsh
approved these changes
Jun 23, 2026
Member
Hmm, to me it looks like only three microbenchmarks improved, and nine other benchmarks showed small regressions? 
(But to be clear I'm not asking for this to be reverted if you have other things building on this, especially since it also improved memory usage) |
Member
Author
|
Hmm.. sorry, I must have misread those. I'll readdress whether this particular case makes sense after I land the followup work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
infer_expression_typesquery cache inference results uniquely for a given expression and type context. For expressions that are not directly affected by type context, we can defer applying the type context until after the Salsa query runs, allowing us to reuse the memoized query result during multi-inference.