[ty] Cache is_never_satisfied results#26261
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.37%. The percentage of expected errors that received a diagnostic held steady at 89.00%. The number of fully passing files held steady at 94/134. |
Memory usage reportMemory usage unchanged ✅ |
|
Merging this PR will improve performance by 4.15%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | DateType |
281.4 ms | 270.1 ms | +4.15% |
Tip
Curious why this is faster? Use the CodSpeed MCP and ask your agent.
Comparing charlie/codex-cache-is-never-satisfied (fab1df6) with main (fc97f12)
Footnotes
-
64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
c9e7acd to
fab1df6
Compare
is_never_satisfied results
is_never_satisfied resultsis_never_satisfied results
MichaReiser
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_never_satisfiedreconstructs root path assignments and traverses the same constraint BDD whenever callers ask the same builder about the same interior root. This adds a builder-local cache keyed by the rootNodeId, allowing repeated top-level queries to reuse the completed boolean result.Only completed top-level calls read or populate the cache. Recursive calls remain uncached because their result depends on the current
PathAssignments, while terminal roots continue to return directly. The cache is local to each query builder, including builder views over compacted owned constraint sets, so cache state does not become part of owned storage.Performance
On the pinned Pydantic
ty_walltimeworkload, a census found that 70.1% of top-level checks repeated a root in the same builder and those repeats accounted for 48.0% of recursive visits. In an adjacent copied-binary comparison with 90 checks per variant, the candidate measured 2.962 s/check versus 3.014 s/check for control, a 1.725% improvement.This is directionally favorable but below the campaign's predeclared 2% and twice-noise acceptance thresholds, so the PR remains a draft for broader performance evaluation rather than a claimed win.