[ty] Skip shadowed submodule bindings during import analysis#26385
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.47%. The percentage of expected errors that received a diagnostic held steady at 89.19%. The number of fully passing files held steady at 95/134. |
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
call-non-callable |
0 | 1 | 0 |
| Total | 0 | 1 | 0 |
Raw diff:
strawberry (https://github.com/strawberry-graphql/strawberry)
- strawberry/cli/__init__.py:15:9 error[call-non-callable] Object of type `<module 'strawberry.cli.app'>` is not callable
Contributor
Author
|
Going to go ahead and merge this to reduce review load, as it's quite simple and I'm confident it's correct, and it has clearly positive impacts. Happy to address post-merge review comments from anyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid registering an
import fromsubmodule definition when the imported name is immediately shadowed by another binding in the same statement.Closes astral-sh/ty#2438
Testing
Added mdtest.