[ty] Improve vendored filesystem concurrency#26408
Merged
Merged
Conversation
Memory usage reportMemory usage unchanged ✅ |
|
|
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.47%. The percentage of expected errors that received a diagnostic held steady at 89.19%. The number of fully passing files held steady at 95/134. |
charliermarsh
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the shared mutex that serialized access to the vendored filesystem. Vendored files now use independent readers backed by shared archive bytes and metadata, allowing concurrent decompression without copying the archive.
This is possible because cloning a
ZipArchivecan be cheap, when the underlying data is cheap clonable, which is the case for ty. The data is cheap clonable because one is a&'static [u8]and the other variant is anArc<[u8]>, both haveO(1)clone.Performance
A 1% improvement on most project benchmarks. Might be more on runners that support higher concurrency
Test Plan
Testing: Added concurrent read coverage and ran crate tests, Clippy, repository hooks, and a ty build.