Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci(docker): align with ruff/uv build-docker.yml #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaReiser merged 1 commit into from
Dec 25, 2025
Merged

ci(docker): align with ruff/uv build-docker.yml #2217

MichaReiser merged 1 commit into from
Dec 25, 2025

Conversation

@samypr100
Copy link
Contributor

@samypr100 samypr100 commented Dec 25, 2025 •
edited
Loading

Summary

Aligns build-docker.yml with ruff (from f9afcc4) and uv (from b918557)

  1. Changed to read version from pyproject.toml rather than dist-workspace.toml
  2. Ensures alpine 3.23 and trixie are used to start ty with an up-to-date base.
  3. Fixes tag_value usages to align with ruff and uv usage.

zizmor complained about this block because zizmor.yml is missing in this repo. It seems better to avoid a blanket ignore so I've kept it despite the differences. This should be a fix done in ruff side.

permissions:
  contents: read
  # TODO(zanieb): Ideally, this would be `read` on dry-run but that will require
  # significant changes to the workflow.
  packages: write # zizmor: ignore[excessive-permissions]

Test Plan

Did a release on my fork

@samypr100 samypr100 marked this pull request as ready for review December 25, 2025 02:30
MichaReiser
MichaReiser approved these changes Dec 25, 2025
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MichaReiser
Copy link
Member

MichaReiser commented Dec 25, 2025

Looks like the permissions are too broad.

@samypr100
Copy link
Contributor Author

samypr100 commented Dec 25, 2025 •
edited
Loading

Looks like the permissions are too broad.

Thanks, it seems it was failing because the zizmor configuration was missing from ruff zizmor.yml

@samypr100 samypr100 force-pushed the build-docker-cleanup branch from 29bb7ce to 990762e Compare December 25, 2025 18:12
@samypr100
Copy link
Contributor Author

samypr100 commented Dec 25, 2025

Looks like the permissions are too broad.

Thanks, it seems it was failing because the zizmor configuration was missing from ruff zizmor.yml

Should be good to go now. pre-commit should pass. I'll make a PR on ruff side to align on zizmor fixes.

@MichaReiser MichaReiser merged commit 9576196 into astral-sh:main Dec 25, 2025
17 checks passed
@samypr100 samypr100 deleted the build-docker-cleanup branch December 25, 2025 22:41
@samypr100 samypr100 mentioned this pull request Dec 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samypr100 @MichaReiser