Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Correctly generate TSMappedType #16394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2024
Merged

fix: Correctly generate TSMappedType #16394

merged 1 commit into from
Apr 1, 2024
+11 −7

Conversation

liuxingbaoyu
Copy link
Member

Q                       A
Fixed Issues? Fixes #16393
Patch: Bug Fix? √
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? √
Documentation PR Link
Any Dependency Changes?
License MIT

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript pkg: generator labels Mar 29, 2024
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56592

@liuxingbaoyu liuxingbaoyu requested a review from JLHwung April 1, 2024 11:12
@nicolo-ribaudo nicolo-ribaudo merged commit 22725e9 into babel:main Apr 1, 2024
@aczekajski
Copy link

aczekajski commented Apr 1, 2024 •
edited
Loading

@liuxingbaoyu Thank you for the swift fix!
I looked briefly at the PR and I have a feeling that it won't generate the same TS code in these cases:

type Foo2 = { [key in Bar]? };
type Foo3 = { [key in keyof Bar]-? };
type Foo4 = { [key in keyof Bar]+? };

@liuxingbaoyu
Copy link
Member Author

You are right, thank you! I will open a new PR.

@nicolo-ribaudo
Copy link
Member

Ugh, til that's valid TS 😬

@liuxingbaoyu liuxingbaoyu mentioned this pull request Apr 1, 2024
Merged
@aczekajski
Copy link

Suprisingly it is 😂

This was referenced May 18, 2024
Open
Open
@mdfkbtc mdfkbtc mentioned this pull request May 18, 2024
Open
@tiff-es tiff-es mentioned this pull request May 18, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 18, 2024
Open
@AnushaSalian AnushaSalian mentioned this pull request May 19, 2024
Open
@bee22193 bee22193 mentioned this pull request May 20, 2024
Open
@anandgupta193 anandgupta193 mentioned this pull request May 20, 2024
Open
@davidbilling davidbilling mentioned this pull request May 20, 2024
Merged
@bee22193 bee22193 mentioned this pull request May 20, 2024
Open
This was referenced May 20, 2024
Open
Open
Open
@basharat-j basharat-j mentioned this pull request May 20, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request May 20, 2024
Open
@scudette scudette mentioned this pull request May 20, 2024
Closed
@tiff-es tiff-es mentioned this pull request Jun 29, 2024
Open
This was referenced Jun 29, 2024
Open
Open
@mdfkbtc mdfkbtc mentioned this pull request Jun 29, 2024
Open
This was referenced Jun 29, 2024
Open
Open
Open
Open
Open
Open
Open
Open
@bee22193 bee22193 mentioned this pull request Jun 30, 2024
Open
This was referenced Jun 30, 2024
Open
Open
This was referenced Jul 1, 2024
Open
Open
Open
Open
@anandgupta193 anandgupta193 mentioned this pull request Jul 1, 2024
Open
@mdfkbtc mdfkbtc mentioned this pull request Jul 1, 2024
Open
@jamesleesaunders jamesleesaunders mentioned this pull request Jul 1, 2024
Closed
This was referenced Jul 1, 2024
Open
Open
This was referenced Jul 1, 2024
Open
Open
Open
@bee22193 bee22193 mentioned this pull request Jul 2, 2024
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Typescript mapped type with implicit any results in faulty TS

5 participants

@liuxingbaoyu @babel-bot @aczekajski @nicolo-ribaudo @JLHwung