fix: Class reference in type throws error#16816
Merged
Merged
Conversation
liuxingbaoyu
commented
Sep 7, 2024
Member
| Q | A |
|---|---|
| Fixed Issues? | Fixes #16671 |
| Patch: Bug Fix? | √ |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | √ |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58864 |
|
|
||
| const classFieldDefinitionEvaluationTDZVisitor: Visitor<HandleClassTDZState> = { | ||
| ReferencedIdentifier: handleClassTDZ, | ||
| "TSTypeReference|TSExpressionWithTypeArguments|TSTypeQuery|TSQualifiedName"( |
Member
There was a problem hiding this comment.
Can we skip on "TSType" so we are sure we never forget to update this list?
Member
Author
There was a problem hiding this comment.
The difference is whether or not the TSQualifiedName is included, I'm not sure if that has any impact.🤔
Member
Author
There was a problem hiding this comment.
I realized we just need to use TSTypeAnnotation. :)
c521cb0 to
e78a1fb
Compare
JLHwung
approved these changes
Mar 14, 2025
nicolo-ribaudo
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.