Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Workaround Node.js bug for parallel loading of TLA modules #16928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2024
Merged

Workaround Node.js bug for parallel loading of TLA modules #16928

merged 2 commits into from
Oct 24, 2024

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 24, 2024 •
edited
Loading

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Tests in #16850 are failing due to nodejs/node#55516

@babel-bot
Copy link
Collaborator

babel-bot commented Oct 24, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58231

@nicolo-ribaudo nicolo-ribaudo changed the title Add failing test for parallel loading of TLA modules Workaround Node.js bug for parallel loading of TLA modules Oct 24, 2024
@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Priority: High labels Oct 24, 2024
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review October 24, 2024 12:38
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Oct 24, 2024
Merged
@nicolo-ribaudo nicolo-ribaudo merged commit b8002e2 into babel:main Oct 24, 2024
54 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the node-require-async-bug branch October 24, 2024 14:50
@davidjbradshaw davidjbradshaw mentioned this pull request Oct 26, 2024
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 24, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Priority: High

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolo-ribaudo @babel-bot @JLHwung @liuxingbaoyu