Migrate away from @bazel_tools//src/conditions:host_windows
#574
Conversation
The condition has been deprecated at HEAD. None of its usages in skylib were correct as they should all either match on the target or the exec platform, not the host.
|
@katre @meteorcloudy Could you review this for the platform and Windows perspectives? |
meteorcloudy
left a comment
There was a problem hiding this comment.
Thank you, approve from Windows perspective!
katre
left a comment
There was a problem hiding this comment.
This is great! @gregestren was looking into this (to get rid of --host_cpu), so thanks for tackling it.
|
Friendly ping, would be great to have this merged and released |
|
@meteorcloudy @comius Could we get a new skylib release with this fix? https://bazelbuild.slack.com/archives/CA31HN1T3/p1750769722571109 |
|
@fmeum Are you familiar with https://github.com/bazel-contrib/rules-template/blob/main/.github/workflows/release.yaml? Can you help us adopt this workflow for bazel_skylib? |
|
https://github.com/search?q=repo%3Abazelbuild%2Fbazel-skylib%20%2Fbazel_tools.*windows%2F&type=code Hmm I think this PR missed a spot |
Newer versions address a warning about a deprecated feature: bazelbuild/bazel-skylib#574
Newer versions address a warning about a deprecated target: bazelbuild/bazel-skylib#574
The condition has been deprecated at HEAD. None of its usages in skylib were correct as they should all either match on the target or the exec platform, not the host.