Potential fix for code scanning alert no. 13: Potentially unsafe quoting #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeQL always complained about this code and Copilot had a suggestion which solves it even though it wasn't really a problem in practice. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
agaffney
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/blinklabs-io/gouroboros/security/code-scanning/13
To fix the problem, we should avoid manually constructing JSON strings and instead use a structured API that handles quoting and escaping automatically. This can be achieved by using the
json.Marshalfunction to serialize the key-value pairs into JSON format.json.Marshalto ensure proper escaping of quotes and other special characters.generateAstJsonMapfunction to usejson.Marshalfor constructing the JSON string.Suggested fixes powered by Copilot Autofix. Review carefully before merging.