Support for working with transforms #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Informing Watchify about files to watch.
Member
goto-bus-stop
left a comment
There was a problem hiding this comment.
Yay, great! Thanks for getting on that so quickly :)
Left two comments about spelling and markdown syntax, let me know if it's unclear!
| If your custom transform for browserify adds new files to bundle in a non-standard way without requiring. | ||
| You can inform Watchify about these files by emiting 'file' event. | ||
|
|
||
| module.exports = function(file) { |
Member
There was a problem hiding this comment.
Surround this with a fenced code block to make it syntax highlight correctly:
```js
code here
```
readme.markdown
Outdated
| # working with browserify transforms | ||
|
|
||
| If your custom transform for browserify adds new files to bundle in a non-standard way without requiring. | ||
| You can inform Watchify about these files by emiting 'file' event. |
Member
There was a problem hiding this comment.
Some small spelling improvements:
- to bundle → to the bundle
- emiting 'file' event → emitting a 'file' event
Author
|
Done :) |
Author
|
How to merge it? |
goto-bus-stop
approved these changes
Apr 5, 2018
Member
goto-bus-stop
left a comment
There was a problem hiding this comment.
Sorry, missed your update. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informing Watchify about files to watch.