Codestin Search App

JakeGinnivan · 2021-11-07T02:59:28Z

Replaces #420 and #569. Also addresses comment in #478 (comment)

This updates the publishPackage function so it returns 2 things, the publishedPackages and the untaggedPrivatePackages. I wasn't sure how far to take the separation, it could have been it's own module.

Possibly a further step would be to gather up the projects which need to be published & tagged. This would allow changesets to be extended to publish .NET packages to NuGet for instance.

This could also be considered as a breaking change. We possibly should add a new config option to opt into this?

changeset-bot · 2021-11-07T02:59:30Z

🦋 Changeset detected

Latest commit: 7bdce4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@changesets/cli	Minor
@changesets/git	Minor
@changesets/config	Minor
@changesets/types	Minor
@changesets/apply-release-plan	Patch
@changesets/read	Patch
@changesets/release-utils	Patch
@changesets/assemble-release-plan	Patch
@changesets/get-release-plan	Patch
@changesets/changelog-git	Patch
@changesets/changelog-github	Patch
@changesets/get-dependents-graph	Patch
get-workspaces	Patch
@changesets/parse	Patch
@changesets/pre	Patch
@changesets/write	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

JakeGinnivan · 2021-11-07T03:00:27Z

@gakonst @Andarist @mitchellhamilton here is another attempt, I think it addresses (or is closer to addressing) Mitchell's feedback on the other approaches.

JakeGinnivan · 2021-11-07T03:43:54Z

With this approach we would need to fetch tags as well, otherwise it will continually trigger releases

vemundeldegard · 2022-01-16T10:23:35Z

I would love this feature for tagging private packages. I have a combination of private and public. I thought this would come out of the box with Changesets, but sad to see that only published packages is getting tagged...

Andarist · 2022-01-16T11:42:36Z

@vemundeldegard could you describe your use case? With more data we’ll be able to take a better/more informed final decision about this

vemundeldegard · 2022-01-16T11:49:39Z

@vemundeldegard could you describe your use case? With more data we’ll be able to take a better/more informed final decision about this

Sure!

In our project we have a couple of private packages and a couple of public packages. The private packages are basically a handful of AWS Lambdas which are not released to NPM. We want to use Changesets because it offers a handy developer experience for managing versioning and changelog. My understanding is that Changesets do update and merge the changelogs for private our private packages, but as soon as it doesn't merge something to NPM, it will not create a new tag and a GitHub release. Please correct me if this is not right..

The above is the main drawback for us, because we use the releases to trigger additional steps in our workflow, such as deploying the Lambdas. It has forced us to only use the changeset command, and changeset version. Right now we are experimenting with using release-it to handle the tagging and releasing when a changeset PR is merged.

JakeGinnivan · 2022-02-02T22:55:34Z

@Andarist should I rebase this? It incorporates the feedback from @mitchellhamilton has for the previous 3 attempts

JakeGinnivan · 2022-02-02T22:57:17Z

I am using this via patch-package locally. As for why, I use it to control the releases of featureboard.app to production and manage my changelogs.

miszo · 2022-02-07T15:32:00Z

This looks neat and would address the question asked by me in #745 🙂

JakeGinnivan · 2022-02-08T09:21:30Z

This looks neat and would address the question asked by me in #745 🙂

@miszo Any feedback on the implementation? I think @Andarist is after someone to critically review who needs this feature. I will rebase do at least there are not conflicts to start

miszo

@JakeGinnivan, I guess that besides the little duplication, the implementation looks good.

packages/cli/src/commands/publish/index.ts

codesandbox-ci · 2022-02-08T09:32:02Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7bdce4a:

Sandbox	Source
Vanilla	Configuration

pradel · 2022-02-21T15:11:21Z

I would also be interested to see this one released.
For the use case, I am managing an open-source application where we have apps pushed to docker hub and packages released to npm.
I want to integrate changeset in the repository to manage the versionning + changeset of the apps published to docker as well as the packages. The docker images are built and pushed using a github action listening to git tags pushed to the main branch. The issue we have right now is that the apps are not creating a tag so the GitHub action is not triggered.

JakeGinnivan · 2022-03-03T03:31:48Z

Rebased on main.

miszo · 2022-04-19T13:14:33Z

@JakeGinnivan, @Andarist – can we proceed and merge this pull request? Are there any blockers or other reasons that suggests that this change shouldn't be merged?

JakeGinnivan · 2022-04-28T05:26:00Z

I've rebased again, I am referencing the packages built by codesandbox directly in a number of projects.
But when I rebase they 404 and I have to update all my projects, would love to get this merged.

packages/cli/src/commands/publish/publishPackages.ts

Andarist · 2022-05-21T08:29:55Z

I think that:

we don't have to distinguish between private and public packages externally, only publishPackages has to care about this, its return value shouldn't though
we might want to create those tags conditionally (to not change this behavior in a minor version). We should either introduce a config flag or a CLI flag for this. Do you have any preference as to which it should be?

JakeGinnivan · 2022-05-22T02:14:24Z

we don't have to distinguish between private and public packages externally, only publishPackages has to care about this, its return value shouldn't though

Eventually I think this function should not actually publish, instead return the packages which should be published then have multiple publish strategies like publish to NPM, run command etc.

This will allow these private packages to maybe have a release script which can be invoked by changesets to do a custom release (to gems or something).

we might want to create those tags conditionally (to not change this behavior in a minor version). We should either introduce a config flag or a CLI flag for this. Do you have any preference as to which it should be?

Added a config flag enablePrivatePackageTracking

JakeGinnivan · 2022-05-22T02:16:21Z

we don't have to distinguish between private and public packages externally, only publishPackages has to care about this, its return value shouldn't though

Further to this, tagging is done outside of the publishPackages function. So I need to return the unpublished private packages so I don't need to duplicate the tagging code

JakeGinnivan · 2022-05-22T02:38:55Z

@Andarist have addressed feedback, rebased, added some doco and also implemented the changes in #720 which takes the config value into account so it will also fix #620

Co-authored-by: Mateusz Burzyński <[email protected]>

packages/config/src/index.ts

packages/config/schema.json

packages/types/src/index.ts

packages/config/src/index.ts

packages/types/src/index.ts

…pes packages

mino01x · 2022-10-19T09:34:59Z

packages/cli/src/commands/add/isListablePackage.ts

+    return false;
+  }
+
+  if (!config.privatePackages && packageJson.private) {


is something wrong here? because config.privatePackages is always Object

!config.privatePackages?.version && packageJson.private

or i misunderstand?

@mino01x is it causing an issue? If it is then we need to write a test around it

#985 yes i have create a pr. you can help me to check it.

ghost · 2022-10-21T04:42:58Z

packages/cli/src/commands/add/isListablePackage.ts

@@ -0,0 +1,17 @@
+import { Config } from "@changesets/types";
+import { PackageJSON } from "@changesets/types";


import type { PackageJSON } from "@changesets/types";

I think both import can be type import

Andarist mentioned this pull request Dec 14, 2021

Omit private packages from lists of changed and unchanged packages offered by the CLI when running yarn changeset #620

Closed

Andarist mentioned this pull request Feb 7, 2022

[Question] Is there a way to create a GitHub release without publishing the package to registry? #745

Open

JakeGinnivan force-pushed the feat/TrackPrivateProjects branch from 9aa8191 to 99d337c Compare February 8, 2022 09:27

miszo approved these changes Feb 8, 2022

View reviewed changes

packages/cli/src/commands/publish/index.ts Show resolved Hide resolved

JakeGinnivan force-pushed the feat/TrackPrivateProjects branch from 2c0f53a to 0a652ea Compare February 8, 2022 09:33

pradel mentioned this pull request Feb 21, 2022

Changelog page sigle/sigle#255

Closed

JakeGinnivan force-pushed the feat/TrackPrivateProjects branch from 0a652ea to 7e4af7f Compare March 3, 2022 00:38

JakeGinnivan force-pushed the feat/TrackPrivateProjects branch from 7e4af7f to 25d4047 Compare April 27, 2022 02:18

Andarist reviewed May 21, 2022

View reviewed changes

packages/cli/src/commands/publish/publishPackages.ts Outdated Show resolved Hide resolved

Andarist reviewed May 21, 2022

View reviewed changes

packages/cli/src/commands/publish/publishPackages.ts Outdated Show resolved Hide resolved

JakeGinnivan force-pushed the feat/TrackPrivateProjects branch from 25d4047 to f2029e8 Compare May 22, 2022 02:37

JakeGinnivan and others added 7 commits September 29, 2022 12:24

Update packages/cli/src/commands/add/createChangeset.ts

3886e90

Co-authored-by: Mateusz Burzyński <[email protected]>

Fixed duplication of logic when filtering listable packages

c062b16

Removed flags enum and simplified config

f0ece83

Added cwd to tagExists and fixed tests

4dd972e

Hoist tagging private packages out of publish package

6047290

Addressed feedback

2f158d5

Fix linting issues after rebase

3e9f3b9

JakeGinnivan force-pushed the feat/TrackPrivateProjects branch from 046da53 to 3e9f3b9 Compare September 29, 2022 05:06