Conversation
🦋 Changeset detectedLatest commit: a40b203 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a40b203:
|
emmatown
approved these changes
Feb 24, 2022
Member
Yeah, I think being explicit about it would be nice |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #737
The problem is that all functions in
@changesets/loggeracceptanys and I think that should be fixed cause it can lead to mistakes like this.This could be fixed with this patch:
patch
However, this would require further changes in the codebase and I didn't want to make them right now. Mainly all
.catched errors would become harder to pass tologger.error:changesets/packages/cli/src/utils/cli-utilities.ts
Lines 84 to 86 in 75c30fc
On the other hand, this is somewhat desirable, because at least we'd have to make the explicit conversion at those call sites. Thoughts?