Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix nats integration tests #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

Fix nats integration tests #710

merged 1 commit into from
Aug 18, 2021

Conversation

benmoss
Copy link
Contributor

@benmoss benmoss commented Aug 18, 2021 •
edited
Loading

Not really sure why this was broken, I was getting this error when running these locally:

go test -v -parallel 1 -timeout 10m -race -covermode=atomic -coverprofile=coverage.tmp -coverpkg "$COVERPKG" github.com/cloudevents/sdk-go/test/integration/nats
go: github.com/cloudevents/sdk-go/protocol/nats/[email protected] requires
        github.com/nats-io/nats-server/[email protected]: missing go.sum entry; to add it:
        go mod download github.com/nats-io/nats-server/v2

I ran go mod tidy and it made these changes to go.mod and go.sum. I bumped the nats image just since it seemed out of date.

@n3wscott
Copy link
Member

GREEN again!!
Thanks Ben!!

LGTM

@n3wscott n3wscott merged commit 70febdc into cloudevents:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmoss @n3wscott