Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Format containers api errors better #10321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

Format containers api errors better #10321

merged 2 commits into from
Aug 13, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Aug 11, 2025 •
edited
Loading

Fixes CC-5500

instead of just dumping the json, we get this slightly prettier error
Screenshot 2025-08-12 at 11 18 08

  • Tests
    • Tests included
    • Tests not necessary because: error formatting
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: error formatting
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not backporting stuff that was not public in v3

@emily-shen emily-shen requested a review from a team as a code owner August 11, 2025 14:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 064abed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Aug 11, 2025
emily-shen
emily-shen commented Aug 11, 2025
View reviewed changes
packages/wrangler/src/containers/deploy.ts
}

throw new UserError(
`Error creating application due to an internal error (request id: ${err.body.request_id}):\n${formatError(err)}`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't seem to ever be getting a request id so let's just get rid of this

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 11, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10321

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10321

miniflare

npm i https://pkg.pr.new/miniflare@10321

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10321

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10321

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10321

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10321

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10321

wrangler

npm i https://pkg.pr.new/wrangler@10321

commit: 064abed

@emily-shen emily-shen force-pushed the emily/prettier-errors branch from cd8783a to 8ace61e Compare August 11, 2025 15:02
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 12, 2025
@CarmenPopoviciu
Copy link
Contributor

should the PR contain a changeset since these are user-facing changes?

@github-actions GitHub Actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/prettier-errors might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10321
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@emily-shen emily-shen added the skip-v3-pr Skip validation of presence of a v3 backport PR label Aug 12, 2025
@emily-shen emily-shen merged commit b524a6f into main Aug 13, 2025
69 of 92 checks passed
@emily-shen emily-shen deleted the emily/prettier-errors branch August 13, 2025 12:32
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 13, 2025
@workers-devprod workers-devprod mentioned this pull request Aug 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu approved these changes

Assignees

No one assigned

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emily-shen @CarmenPopoviciu