-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(wrangler): show correct port in scheduled worker warning #11494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0acb3cc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Hey @jalmonter! Thanks for opening this PR, I didn't even realise you had already created a fix for this before opening my PR. If you wouldn't mind adding some tests to make sure this issue doesn't crop up again (Feel free to use the tests I created in #11731) and I'll go ahead and get this merged ASAP. Or if need be I am happy to import my tests to your branch if you'd prefer? 😄 |
|
Hey @NuroDev, I've imported the tests from your branch and added a changeset. This should be good to go unless checks fail, which require someone's approval before they can run. |
|
Merged! This will be available in the next release of |
Issue: When running
wrangler devwith a worker that has cron triggers, the warning message displayed an invalid URL likecurl "http://localhost:undefined/cdn-cgi/handler/scheduled"because the port wasn't yet determined when the warning was logged.Fix: Moved the warning to after the proxy server is fully ready, where the actual public URL and port are known.