feat: add notification preferences database & audit support #14100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2024
|
✅ Meticulous spotted zero visual differences across 468 screens tested: view results. Expected differences? Click here. Last updated for commit 5d683d4. This comment will update as new commits are pushed. |
76d4ca5 to
85ec862
Compare
85ec862 to
8333dcb
Compare
8333dcb to
93a92d6
Compare
This was referenced Aug 2, 2024
2105aa4 to
c4b8b31
Compare
Emyrk
reviewed
Aug 2, 2024
coderd/database/migrations/000237_notification_preferences.up.sql
Outdated
Show resolved
Hide resolved
coderd/database/migrations/000237_notification_preferences.up.sql
Outdated
Show resolved
Hide resolved
coderd/database/migrations/testdata/fixtures/000237_notifications_preferences.up.sql
Outdated
Show resolved
Hide resolved
dannykopping
commented
Aug 5, 2024
There was a problem hiding this comment.
Thanks for the review @Emyrk 👍
User's have NotificationPreference which relates to NotificationTemplate. But only admins/owners can setup NotificationTemplate?
Correct; notification templates only store system-level templates right now; the design will evolve to allow operators to create their own notification templates.
coderd/database/migrations/000237_notification_preferences.up.sql
Outdated
Show resolved
Hide resolved
coderd/database/migrations/000237_notification_preferences.up.sql
Outdated
Show resolved
Hide resolved
coderd/database/migrations/testdata/fixtures/000237_notifications_preferences.up.sql
Outdated
Show resolved
Hide resolved
6ea0336 to
2cc690c
Compare
johnstcn
reviewed
Aug 5, 2024
johnstcn
reviewed
Aug 5, 2024
johnstcn
reviewed
Aug 5, 2024
johnstcn
reviewed
Aug 5, 2024
johnstcn
approved these changes
Aug 5, 2024
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
… kind Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
2cc690c to
c744d33
Compare
Signed-off-by: Danny Kopping <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of coder/internal#19
NOTE: I used Graphite for this, but it's got too many sharp edges. I'm reverting to manually managing these branches.
This implements the foundation of the feature - namely the database changes, along with auditing support and RBAC - all used in upstack PRs. I initially had these 3 elements in separate branches, but it became too much of a PITA to maintain with Graphite. In the future I'll start with one big branch and decompose before review time instead of decomposing ahead of time.
THIS PR MUST BE MERGED LAST!